search

SArpnt / bytebeat-composer

Bytebeat player with playlist that contains many interesting formulas from the Internet.
https://sarpnt.github.io/bytebeat-composer/
MIT License
13 stars 2 forks source link

Rendering problems #2

Closed SthephanShinkufag closed 3 years ago

SthephanShinkufag commented 3 years ago

  1. Drawing has become more jittery because of this. https://github.com/SArpnt/bytebeat-composer/commit/1ad339b12563e073d6f87f9a6d7bf9809f639759#diff-124a4ae5cf8b9af2d21923d36e8934502d13b1a553ff27df1fa07cfa06fb99a4R13

  2. Look up for max zoom. The graph is no longer drawn to the end.

  3. You have a typo here: https://github.com/SArpnt/bytebeat-composer/commit/beaa6146d706162cc168332e07f762379f88aee6#diff-124a4ae5cf8b9af2d21923d36e8934502d13b1a553ff27df1fa07cfa06fb99a4R485

SArpnt commented 3 years ago
  1. if you mean the buffer size change, i feel like more reliable audio is more important than the speed of the cursor when rendering
  2. i'll move this to #3, i already know what causes the bug
  3. that's the optional chaining operator, it's there intentionally
SthephanShinkufag commented 3 years ago

optional chaining operator Chrome 80 Firefox 74

Oh, ok, I didn't know about this technology. Before your fork, I tried to support old browsers as much as possible, abandoning the ESNext features. And finally I decided to drop very old browsers using arrow functions, deconstruction, and so on. But this is a very recent technology, some users may have problems.

SArpnt commented 3 years ago

this is a very recent technology, some users may have problems.

i don't think this is a problem for a few reasons: