search

SAtacker / bb-config

Configure your beagle device
MIT License
41 stars 7 forks source link

Emmc sd. #25

Closed ArthurSonzogni closed 3 years ago

ArthurSonzogni commented 3 years ago

Hi, I made two improvement to your branch.

Could you please take a look?

SAtacker commented 3 years ago

Am I missing something?

/home/satacker/Desktop/beagle-config/src/ui/panel/emmc/emmc_impl.cpp: In function ‘std::__cxx11::wstring ui::{anonymous}::Format(float, ui::{anonymous}::sizeApprox)’:
/home/satacker/Desktop/beagle-config/src/ui/panel/emmc/emmc_impl.cpp:25:28: error: ‘setprecision’ is not a member of ‘std’
   ss << std::fixed << std::setprecision(2) << (value / float(unit));
                            ^~~~~~~~~~~~
/home/satacker/Desktop/beagle-config/src/ui/panel/emmc/emmc_impl.cpp:25:28: note: suggested alternative: ‘set_union’
   ss << std::fixed << std::setprecision(2) << (value / float(unit));
                            ^~~~~~~~~~~~
                            set_union
/home/satacker/Desktop/beagle-config/src/ui/panel/emmc/emmc_impl.cpp:35:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/beagle-config.dir/build.make:89: CMakeFiles/beagle-config.dir/src/ui/panel/emmc/emmc_impl.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:284: CMakeFiles/beagle-config.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Edit: Simple issue

SAtacker commented 3 years ago

Thanks, @ArthurSonzogni ! The table looks sweet. A tiny concern that the button is displayed with a bottom edge missing :sweat: asciicast

ArthurSonzogni commented 3 years ago

Hey, I addressed all your comments. I also added gauge to visualize the remaining space left.