search

SAtacker / bb-config

Configure your beagle device
MIT License
41 stars 7 forks source link

Use Individual PRU. #29

Closed ArthurSonzogni closed 3 years ago

ArthurSonzogni commented 3 years ago

Refactor: https://github.com/SAtacker/beagle-config/pull/27

Use a class to represent an individual PRU. This lead to simpler and 2x shorter code.

Moreover, the buttons about a PRU are group with the info about the PRU.

ArthurSonzogni commented 3 years ago

Hi @SAtacker Could you please take a look?

ArthurSonzogni commented 3 years ago

Note that I wasn't able to test locally on a real device. You might want to bring back the feature about checking the existence of the firmware maybe?

SAtacker commented 3 years ago

Refactor:

27

Use a class to represent an individual PRU. This lead to simpler and 2x shorter code.

Moreover, the buttons about a PRU are group with the info about the PRU.

Thanks, @ArthurSonzogni !

SAtacker commented 3 years ago

Note that I wasn't able to test locally on a real device. You might want to bring back the feature about checking the existence of the firmware maybe?

Yes actually the little info would be nice, I'll make the changes over your PR and send it on dev . Thanks!