SAtacker / bb-config

Configure your beagle device
MIT License
41 stars 7 forks source link

SSH and Passwd #36

Closed SAtacker closed 3 years ago

SAtacker commented 3 years ago

asciicast

ArthurSonzogni commented 3 years ago

Thanks! Input elements seems to always appear as "Focused". I believe this was a bug I introduced recently and fixed in: https://github.com/ArthurSonzogni/FTXUI/pull/188/commits/3657b3426aadb7867652c6c14b99fe92f67e0201 You probably want to refresh FTXUI version to the latest commit to avoid thi.

SAtacker commented 3 years ago

In case someone wants to verify what they have typed, a small text region is useful.

On Mon, 16 Aug, 2021, 13:52 Arthur Sonzogni, @.***> wrote:

@.**** approved this pull request.

In src/ui/panel/passwd/passwd.cpp https://github.com/SAtacker/beagle-config/pull/36#discussion_r689330503:

  • input_np = Input(&new_pass, "New Password", inp_opt);
  • change_ = Button("Change", [&] {
  • auto cmd = "passwd " + user;
  • FILE* fp = popen(cmd.c_str(), "w");
  • fprintf(fp, "%s\n", pass.data());
  • fprintf(fp, "%s\n", new_pass.data());
  • fprintf(fp, "%s\n", new_pass.data());
  • pclose(fp);
  • });
  • page = Renderer(Container::Vertical({
  • input_p,
  • input_np,
  • change_,
  • }),
  • [&] {
  • if (view) {

I don't understand what the goal of "view" here. Could you please explain it to me? It seems this cause the layout to shift when you press enter.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SAtacker/beagle-config/pull/36#pullrequestreview-730445157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOXPF5P7W6C2BYKDRKZJH7TT5DDFPANCNFSM5CF77GAQ .

SAtacker commented 3 years ago

Thanks, I'll update it.

On Mon, 16 Aug, 2021, 13:47 Arthur Sonzogni, @.***> wrote:

Thanks! Input elements seems to always appear as "Focused". I believe this was a bug I introduced recently and fixed in: @.*** https://github.com/ArthurSonzogni/FTXUI/commit/3657b3426aadb7867652c6c14b99fe92f67e0201 You probably want to refresh FTXUI version to the latest commit to avoid thi.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SAtacker/beagle-config/pull/36#issuecomment-899316890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOXPF5NSIRWJFSM3QWSGBQTT5DCRHANCNFSM5CF77GAQ .