SBC-Utrecht / PyTom

PyTom software for cryo-tomogram processing
GNU General Public License v2.0
33 stars 8 forks source link

wrong shift determined by subPixelMaxSpline function in gpuStructures.py #64

Open alncat opened 3 months ago

alncat commented 3 months ago

Dear PyTom developer, I noticed that there is a bug in the subPixelMaxSpline function in gpuStructures.py when you are using binned subtomograms. For example, if you have specified --binning 2 when using GLocalJob.py, the shift found by subPixelMaxSpline function is for the binned subtomogram. To get the shift for unbinned subtomogram, we need to multiply this shift with the binning factor before return. I propose the following modification,

#get the ubinned shift
peak_shift = [ip*self.binning for ip in peak_shift]

return peak_value, peak_shift

Best Regards, Zhenwei