SBC-Utrecht / PyTomPrivate

Development repository
GNU General Public License v2.0
2 stars 2 forks source link

Xml2star conversion particle path bug #130

Closed McHaillet closed 1 year ago

McHaillet commented 1 year ago

Pytom writes particle annotions in .xml format, but for compatibility with Relion and Warp it needs to be converted to a .star file format. Pytom already supported conversion to a simplistic pickpostion format that could be read by warp for subtomogram reconstruction. I now added support to allow back and forth conversion with star files that refer to subtomograms and ctf volumes that Relion needs for subtomogram averaging and classification.

I updated unittests to make sure the old behaviour is consistent, and the back and forth conversion with the updated format is consistent (no information loss).

McHaillet commented 1 year ago

and I would very much also like unittest for the newly added fail paths (so the code should fail with the expected error if it is asking with tomo data without the new keywords)

Good point, will do!

McHaillet commented 1 year ago

I updated as requested:

And also changed the following: