SBC-Utrecht / PyTomPrivate

Development repository
GNU General Public License v2.0
2 stars 2 forks source link

Loosen install requirement #150

Closed sroet closed 1 year ago

sroet commented 1 year ago

This loosens the install requirements.

Currently it does not fail in more test than current master (test_pytomvolume_vs_numpy.py fails on the rotation) and the test_pytom_FullPipeline.py has not been run

McHaillet commented 1 year ago

Apparently some issues on the docker setup. Locally it did work I assume?

sroet commented 1 year ago

It seems like the package name is fftw, but I need to check to make sure the mpi version is pulled correctly and not the default 'no_mpi' (https://anaconda.org/conda-forge/fftw/files)

sroet commented 1 year ago

@McHaillet All green, could you have another look and test if the cupy install also works (running some of the gpu tests would be great)

McHaillet commented 1 year ago

I ran it on my WSL installation and it runs pretty smoothly. I only fail the pytom_MPI test with the following

ModuleNotFoundError: No module named '_pytom_mpi'

and I get this message everywhere (which does not seem to hinder as the tests succeed)

The C-functionality of PyTom failed to load. For full functionality, please run pytom or ipytom.

I will also try it on my home Ubuntu laptop with GPU because WSL can be problematic.

McHaillet commented 1 year ago

Installation also works fine with mamba. All tests pass now!

This message is also gone (it was because of the _pytom_mpi failing to load): The C-functionality of PyTom failed to load. For full functionality, please run pytom or ipytom.

McHaillet commented 1 year ago

We should still consider the gcc compilers though...

sroet commented 1 year ago

We should still consider the gcc compilers though...

I agree, added those in https://github.com/SBC-Utrecht/PyTomPrivate/pull/150/commits/a6cbe34a6028e78d8b47230be075705110e83a4f

sroet commented 1 year ago

@McHaillet Please have another look at the gui functions (I tried to open most windows, but you might have some more typical interaction with the GUI)

McHaillet commented 1 year ago

For me it also works. Probably will start the pipeline test on my home laptop when I come to work