SBC-Utrecht / pytom-match-pick

GPU-accelerated template matching for cryo-ET
https://sbc-utrecht.github.io/pytom-match-pick/
GNU General Public License v2.0
29 stars 9 forks source link

Get tutorial-tests.yml working #226

Closed sroet closed 3 months ago

sroet commented 3 months ago

Alright, I am rerunning this job only on this branch until I get it working

closes #148

github-actions[bot] commented 3 months ago

File Coverage Missing
All files 88% :white_check_mark:
src/pytom_tm/correlation.py 85% :x: 98-99 131
src/pytom_tm/entry_points.py 79% :x: 28 113-130 235-280 385-404 540-558 1038-1049
src/pytom_tm/extract.py 76% :x: 127-138 205-212 256-261 354-372
src/pytom_tm/io.py 81% :x: 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 434-442 467
src/pytom_tm/mask.py 80% :x: 76 94 104-105
src/pytom_tm/parallel.py 89% :white_check_mark: 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% :x: 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% :white_check_mark: 372-373 389 399-404 483 611 660
src/pytom_tm/utils.py 78% :x: 18-20
src/pytom_tm/weights.py 96% :white_check_mark: 59 314-318 325 535 540 545

Minimum allowed coverage is 87%

Generated by :monkey: cobertura-action against dee2f0a0fdeb06ae7d122ab329c4cff159731260

sroet commented 3 months ago

@McHaillet This finally works! It runs in 101 min, and can be seen here: https://github.com/SBC-Utrecht/pytom-match-pick/actions/runs/10425169098/job/28875465809 (commit 4ba5eda, which failed on ruff stuff in the regular unitests)

With that runtime, it might be worthwhile to actually pip install cupy, what do you think?

sroet commented 3 months ago

It also already found the first error in the tutorial :sweat_smile:

McHaillet commented 3 months ago

It also already found the first error in the tutorial 😅

Nice! What was the error?

sroet commented 3 months ago

It also already found the first error in the tutorial 😅

Nice! What was the error?

the file you get from emdb is called emd_2938.map instead of emd_2938.mrc (was mentioned that way in the file structure)