SBNSoftware / icaruscode

Main/top level repository for ICARUS specific code
11 stars 33 forks source link

Warning in PMT digitisation: "Check on sampled photoelectron waveform template failed!" #449

Open PetrilloAtWork opened 2 years ago

PetrilloAtWork commented 2 years ago

PMT digitisation simulation emits these warnings:

%MSG-w PMTsimulationAlg:  SimPMTIcarus:opdaq@BeginModule  16-Sep-2022 17:41:50 CDT run: 1 subRun: 0 event: 4
Check on sampled photoelectron waveform template failed!
 => high tail at the end of sampling (842 ns) is still at -0.0351564 #
Shape parameters:Pulse 'SPR202202' (v. 1, n/a):
    average waveform of channel 258 of run XXXX
    from 804x 1 ns samples, peak at 55.1 ns with amplitude -32.8509 #
    start at 39.1 ns, gain 9.7e+06 (integral: -638.122 #)

%MSG

The single photon response is supposed to be defined widely enough that it has already faded out at the end of the interval of definition. With our current data-driven SPR (202202), this is not the case and the warning is triggered. The best solution is not clear (whether to work around the warning or to change the SPR).

The relevant code is somewhere in icaruscode/PMT/Algorithms.

wesketchum commented 1 year ago

@PetrilloAtWork is this still an issue?