search

SBNSoftware / icaruscode

Main/top level repository for ICARUS specific code
11 stars 34 forks source link

NuMI XSec 2024 Updated Production Patch: Gray's update to angular dependence of recombination #687

Open brucehoward-physics opened 9 months ago

brucehoward-physics commented 9 months ago

This change brings with it needs to icaruscode and larreco (as it's handled in a calibration for the data)

Two ways this might be handled:

  1. Gray has a larreco feature branch (feature/gputnam-angcalo)
  2. These commits or something like them were merged into develop larreco (fc790c0f80d4fc90d892abe467be4084835e2d6e and 3f7b79423dab53b75bce8f42ff149cb3afe092c9) and so a nice way might be to have a tag made by larsoft if possible with these included.
brucehoward-physics commented 8 months ago

Partly covered in #694 BUT still need the larreco changes.

SFBayLaser commented 8 months ago

I don't think the LArSoft people can do anything with larreco until there is a pull request. They have a procedure that they will then follow to make the needed release.

brucehoward-physics commented 8 months ago

https://github.com/LArSoft/larreco/pull/63 and email communication with scisoft underway

brucehoward-physics commented 7 months ago

Updating on status: We met with @miquelnebot and @ibsafa this morning and I think they will be able to follow the LArSoft needs to make the tag, but we need to give them some more info about if there are other LArSoft branches we'll touch. Will work on deciding/following up on this today 🤞

jedori0228 commented 4 months ago

This has been done by having a new larreco release: https://github.com/LArSoft/larreco/tree/v09_17_06_01