search

SBNSoftware / icaruscode

Main/top level repository for ICARUS specific code
11 stars 33 forks source link

Fix ML chain for ICARUS systematics and standard productions #734

Closed jzettle closed 4 months ago

jzettle commented 4 months ago

This PR is meant to try to fix the issue seen in v09_89_01 with Supera running when attempting to test things for the variation. Also includes small changes needed for ML running in a couple of the variation fcl. This PR supersedes https://github.com/SBNSoftware/icaruscode/pull/733 and was made in coordination with @yeonjaej ensuring I had included the same changes she did in her PR. Making this against develop as that and the v09_89_01 tag are identical according to github.

Still testing this with the neutrino-only samples to make sure the issue is fixed to the level we can quickly. Also notifying @cerati and @SFBayLaser about this. Will comment results of testing over the rest of the night/tomorrow morning and we can discuss how to patch the release if everything is successful.

Apparently I cannot request @yeonjaej as a reviewer...?

Relies also on the sbncode PR built against the tag v09_89_01 in sbncode: https://github.com/SBNSoftware/sbncode/pull/460

jzettle commented 4 months ago

That one was my bad, I thought I had to change something to save the wire information in the calibration tuples to validate some of the variations and found it easier with the complete time crunch to save everything from stage0 instead of testing which product from stage0 was the correct one to not drop. Happy to review and update this later once there is more time

mmrosenberg commented 4 months ago

trigger build SBNSoftware/sbncode#460

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:x: CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 4 months ago

:warning: CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard