search

SBNSoftware / icaruscode

Main/top level repository for ICARUS specific code
11 stars 34 forks source link

Set SaveGENIEEventRecord as true be default cafmaker fcl #739

Closed jedori0228 closed 4 months ago

jedori0228 commented 6 months ago

From https://github.com/SBNSoftware/sbncode/pull/459, which is merged to develop, I added a feature to save GENIE event record to the CAFMaker output. Here I set the default value of a boolean, SaveGENIEEventRecord, to true; this is crucial to constantly adopt new cross-section systematics without re-running CAFMaker job. More importantly, we now stopped updating LarSoft/nusystematics but moved to NuSystematics/nusystematics, and there are some missing dials that we cannot currently evaluate from lar based jobs. We can add those once we have GENIE record saved together with StandarRecord.

mmrosenberg commented 6 months ago

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00

FNALbuild commented 6 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 6 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 6 months ago

:x: CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 6 months ago

:warning: CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

brucehoward-physics commented 4 months ago

As is known, I love this addition!

But, I do have a question. How much does this increase the file sizes @jedori0228 ?

Just wondering if we want to turn it on by default or have it as an option with a separate CAF that production requests could use.

jedori0228 commented 4 months ago

As is known, I love this addition!

But, I do have a question. How much does this increase the file sizes @jedori0228 ?

Just wondering if we want to turn it on by default or have it as an option with a separate CAF that production requests could use.

I forgot that I have a supporting document related to this PR: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=36869

The increment in the file size was 0.5% (when compared to a CAF that has no weights).

brucehoward-physics commented 4 months ago

That seems pretty small given that CAFs are already smaller. Approved.

mmrosenberg commented 4 months ago

trigger build

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:x: CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 4 months ago

:warning: CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard