search

SBNSoftware / sbnana

4 stars 14 forks source link

Remove unused SREnums.h #42

Closed cjbacchus closed 3 years ago

cjbacchus commented 3 years ago

Remove this copy of SREnums.h. It is unused, but could be confused for the real one in sbnanaobj/StandardRecord. And in fact the experiment enum differs, so that would be bad.

cjbacchus commented 3 years ago

@miquelnebot this is trivial, but I guess we should put it through the CI in case I missed a place that does depend on this?

miquelnebot commented 3 years ago

@miquelnebot this is trivial, but I guess we should put it through the CI in case I missed a place that does depend on this?

@cjbackhouse, sbnana has not CI integrated (apart from nightly builds after the merge) so if a build test (choose a flavour) could be checked first I'll be happy to give the GO.

cjbacchus commented 3 years ago

I meant an automated build test. It built locally for me e20:prof, so it should be fine.