search

SBNSoftware / sbnana

3 stars 14 forks source link

Supporting XRootD #43

Open jedori0228 opened 2 years ago

jedori0228 commented 2 years ago

When we use a XRootD path (useful for grid jobs) in SpectrumLoader, this file does not pass the following line, and is neglected, since stat() returns non-zero value. https://github.com/SBNSoftware/sbnana/blob/5df8255a798540bd4187dee6e290509bf88b3c8c/sbnana/CAFAna/Core/Utilities.cxx#L539-L540 A XRootD file can be used if stat() is commented out (but still the wildcard will not work for XRootD path).

cjbacchus commented 2 years ago

There is special logic in WildcardSource to let through /pnfs/ locations (not xrootd'd locations) even if they can't be found https://github.com/SBNSoftware/sbnana/blob/develop/sbnana/CAFAna/Core/WildcardSource.cxx

and then in FileListSource it is supposed to automatically translate pnfs paths into their xrootd equivalents. https://github.com/SBNSoftware/sbnana/blob/develop/sbnana/CAFAna/Core/FileListSource.cxx#L98

So, all of this should work if you just let CAFAna xrootd your paths for you. Except, the line in FileListSource is commented out (it exists in the nova version) for some reason. Can you try uncommenting this and running with a /pnfs/ path to see what happens?

cjbacchus commented 2 years ago

Oh, hang on. We would also need a return wildcard; after the warning in WildcardSource. So could you try with both of those changes included?

jedori0228 commented 2 years ago

Sorry for the late response. I checked uncommenting https://github.com/SBNSoftware/sbnana/blob/21333eefdf4fe23a6a1f1103b08e86a2358cfab1/sbnana/CAFAna/Core/FileListSource.cxx#L98 and just using /pnfs/ path works, except that I had to also modify https://github.com/SBNSoftware/sbnana/blob/48c0041fc246b310fb044ee489fbacd4416fca5f/sbnana/CAFAna/Core/Utilities.cxx#L820 : fndcagpvm01 -> fndca1

wesketchum commented 2 years ago

@jedori0228 @cjbackhouse is this still an oustanding issue, or what is the status here?

cjbacchus commented 2 years ago

I think the best way forward is for @jedori0228 to make a PR with the two changes mentioned above.

wesketchum commented 1 year ago

@jedori0228 @cjbackhouse did this ever happen?

cjbacchus commented 1 year ago

Comment above is still relevant. That said, this fix is in cafanacore (used by the RecordSource branch), I believe. So we could get it that way too.