search

SBNSoftware / sbnana

4 stars 14 forks source link

Implement NuMI flux systs using external histogram file #47

Closed cjbacchus closed 2 years ago

cjbacchus commented 3 years ago

The histogram file needs to be located somewhere official, probably sbndata? That is the main thing preventing merging this.

wesketchum commented 3 years ago

@cjbackhouse @miquelnebot is this something that needs to be added to sbndata?

cjbacchus commented 3 years ago

That seems by far the most natural to me. The file is currently found in https://gitlab.com/apwood93/numi-at-icarus-flux-systematics.git You should probably coordinate with Anthony Wood and Dan Cherdack about whether they're happy to have what's there now packaged, and what the system for asking for updates in future will be.

miquelnebot commented 2 years ago

@cjbackhouse NuMI at ICARUS flux now added to sbndata in v01_01 when ready, please convert the Draft to full PR and choose a reviewer.

cjbacchus commented 2 years ago

Where is sbndata installed? ups doesn't seem to know about it, even after I set up sbndcode.

cjbacchus commented 2 years ago

huh, I see it at /cvmfs/sbn.opensciencegrid.org/products/sbn/sbndata/, which ups list claims it's searching...

jzennamo commented 2 years ago

@jacoblarkin and @etyley any news on reviewing this PR before Friday? Thanks!