search

SBNSoftware / sbnana

4 stars 14 forks source link

Initial sketch of an automated cut optimizer. #50

Closed cjbacchus closed 3 years ago

cjbacchus commented 3 years ago

I found this lying around in a branch and don't want to completely lose it. Did you ever get a chance to play with this Elizabeth?

wesketchum commented 3 years ago

@cjbackhouse will it hurt to merge in? If not, let's find a reviewer and get it in?

cjbacchus commented 3 years ago

Shouldn't do any harm, but there's no guarantee it works exactly as advertised. I guess we can merge it to reduce clutter.

miquelnebot commented 3 years ago

@cjbackhouse @jzennamo @wesketchum did someone check that this actually builds? clang complains about CutOptimizer.cxx:83:18

cjbacchus commented 3 years ago

@miquelnebot Should read best_fom = fom;. Clever clang... I guess this is a lesson about always triggering the build, even if the code seems fairly trivial.

miquelnebot commented 3 years ago

Thanks @cjbackhouse Problem is sbnana does not have CI But yes, I always check locally beforehand.