search

SBNSoftware / sbnana

4 stars 14 forks source link

pull/57 rebased on release/SBN2021C #59

Closed jedori0228 closed 2 years ago

jedori0228 commented 2 years ago

With https://github.com/SBNSoftware/sbncode/pull/238, the structure of weight values saved in the (flat)caf is changed. This PR will handle the changes in the sbncode, and also an example script sbnana/CAFAna/test/test_GENIESyst.C is added. https://github.com/SBNSoftware/sbnanaobj/pull/47 should be merged together.

Related docdb : https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=24726

cjbacchus commented 2 years ago

I had enough comments, about simplifying further, but also about separating multisigma and multisim mode, that I found it easier to experiment with a new version of this. I reused a lot of what's here, and it was very helpful, but with a slightly different overall structure. Could you take a look at https://github.com/SBNSoftware/sbnana/pull/61 and make sure it makes sense to you?

jedori0228 commented 2 years ago

Moved to #61