search

SBNSoftware / sbnana

4 stars 14 forks source link

Feature/rh test caf #79

Closed rhowell42 closed 1 year ago

rhowell42 commented 2 years ago

I changed the basic variables and cuts to accommade the new CAF reco structure change. These have the same functionality as before, where the desired track or shower is grabbed that has the appropriate trackscore. This request depends on other pull requests in SBNSoftware/sbnanaobj and SBNSoftware/sbncode.

https://github.com/SBNSoftware/sbnanaobj/tree/feature/rh_testCAF https://github.com/SBNSoftware/sbncode/tree/feature/rh_allPFOs

etyley commented 2 years ago

We also probably need to have a collective discussion about the best way to merge these sort of breaking changes in an upcoming meeting, otherwise develop will not work on any of the production that we just made.

cjbacchus commented 2 years ago

Discussion is scheduled at SBN AI tomorrow. The idea I proposed before was to keep the trk and shw branches in parallel in the StandardRecord structure for one release. Then you can try to access whichever (trk/shw or pfp) you think exists in your files.

rhowell42 commented 2 years ago

So you want me to restore the reco->trk/shw branches for that pull request?

miquelnebot commented 2 years ago

Converting this into Draft as agreed in the SBN AI May 31st meeting this will be merged only before the next production SBN2022B release together with SBNSoftware/sbncode#270 and SBNSoftware/sbnanaobj#66

rhowell42 commented 2 years ago

I fixed and pushed the fixes for the badly copied lines above, and also fixed a nue cut