search

SBNSoftware / sbnana

3 stars 14 forks source link

Feature/rh incremental loader #88

Closed rhowell42 closed 1 year ago

rhowell42 commented 1 year ago

Reopening this Pull Request. I added a different way of accessing the recoTree one spill at a time with SpectrumLoader::Select(unsigned int N) which grabs the Nth spill. This accesses an overloaded SpectrumLoader::HandleFile by passing the Nth spill to load. Also adds a SpectrumLoader method that retrieves the number of spills in the CAF files being loaded in.

rhowell42 commented 1 year ago

I think I agree with all your comments, thanks Chris. I was imagining this just working for one input file, but you're right it should take lists of files as well. I'll make your recommended changes

miquelnebot commented 1 year ago

@rhowell42 could you implement or resolve the comments, please?

rhowell42 commented 1 year ago

Yeah, I'll close it. I've almost got it sorted, but it's already taken way too long to implement. I'll reopen in the future when I get it working