search

SBNSoftware / sbnana

3 stars 14 forks source link

Update to hardcoded paths accessing the NuMI flux systs file. #92

Closed woodtp closed 1 year ago

brucehoward-physics commented 1 year ago

It looks like most of the actual substantive changes are just locations/names of products inside the functions that go get stuff from the ROOT file? Did anything else substantive change?

(Note: curious if you ran a style macro over this or something? A lot of small changes here and there don't seem substantive, hence my questions.)

woodtp commented 1 year ago

It looks like most of the actual substantive changes are just locations/names of products inside the functions that go get stuff from the ROOT file? Did anything else substantive change?

(Note: curious if you ran a style macro over this or something? A lot of small changes here and there don't seem substantive, hence my questions.)

That’s correct, I didn’t make any changes other than pointing the paths to the appropriate places in the root file.

Also, yes, although it was unintentional. I have my editor configured to run clang_format automatically on write.

woodtp commented 1 year ago

@miquelnebot, I'm closing this PR to fix the issues @brucehoward-physics spotted with the attenuation and pCQEL systematics.