search

SBNSoftware / sbnana

3 stars 14 forks source link

Brindenc #95

Closed bear-is-asleep closed 1 year ago

bear-is-asleep commented 1 year ago

Used @grayputnam tools from his dimuon python scripts to make a sbnd version in a folder called pyana. Added some tests to ensure it can handle no indexing and indexing from keys.

miquelnebot commented 1 year ago

@bear-is-asleep could you fix the conflicts, please?

miquelnebot commented 1 year ago

@grayputnam @lynnt-uchicago @wjdanswjddl @VCLanNguyen could you add your review, please?

VCLanNguyen commented 1 year ago

@bear-is-asleep Should the changes you make be in a new analysis folder i.e. nue scattering ana. So that it shouldn't conflict with Gray's

bear-is-asleep commented 1 year ago

@bear-is-asleep Should the changes you make be in a new analysis folder i.e. nue scattering ana. So that it shouldn't conflict with Gray's

it is in a different folder. also I only used copied over the code Gray uses to read CAFs, I have nothing dimuon or nuescattering specific in the new folder.

bear-is-asleep commented 1 year ago

@bear-is-asleep could you fix the conflicts, please?

the conflicts have been resolved - I kept everything untouched in Gray's dimuon search folder