SBNSoftware / sbnana

3 stars 14 forks source link

NuMI Flux Sysematics Update #96

Closed woodtp closed 11 months ago

woodtp commented 1 year ago

This PR tied closely with sbndata PR#4 Update NuMI flux file to latest version.

The updates here are necessary to access data correctly from the flux file in the above PR, as the internal structure of the file has undergone several revisions.

Specific Updates:

image

Other modifications:

Again to check that this update still works as expected, below are a selection of true neutrino energy spectra varied according to the various systematics.

numi_beam_div numi_beam_shift_minus_y numi_beam_shift_plus_y numi_beam_shift_x numi_beam_spot numi_horn1_x numi_horn1_y numi_horn_current_plus numi_pc_0 numi_pc_1 numi_pc_2 numi_pc_3 numi_pc_4 numi_water_layer

brucehoward-physics commented 1 year ago

Thanks for this PR Tony -- It looks like I'm the only person tagged as a reviewer and since some of it is stuff I helped put together, I guess I'm thinking we should add another reviewer 😅

@PetrilloAtWork is this one for you or... do you have someone else in mind? Maybe @jedori0228?

jedori0228 commented 1 year ago

Hi, I merged this PR and checked NuMIFluxSysts and NuMIFlux work as expected. Few validation plots added:

beam_spot.pdf

pc_1.pdf

PPFXW.pdf

woodtp commented 1 year ago

I've made another commit, which changes the following:

  1. New feature to the NuMIFluxSyst class allowing the user to specify a path to the fluxfile. It will default to the one defined by the SBNDATA_DIR envvar.
  2. Additional systematic has been added to account for differences between the older beam geometry and the newer 1 MW upgrade to NuMI.
  3. The statistical uncertainty on the flux prediction was omitted in previous versions, so I've added a few lines to load it.
  4. Some minor changes to which histograms are loaded for beam focusing systematics. I realized that these were reading in the fractional uncertainties instead of the systematic shifts, which would cause an improper accounting for correlations between bins.