Closed woodtp closed 11 months ago
Thanks for this PR Tony -- It looks like I'm the only person tagged as a reviewer and since some of it is stuff I helped put together, I guess I'm thinking we should add another reviewer 😅
@PetrilloAtWork is this one for you or... do you have someone else in mind? Maybe @jedori0228?
Hi, I merged this PR and checked NuMIFluxSysts
and NuMIFlux
work as expected. Few validation plots added:
I've made another commit, which changes the following:
NuMIFluxSyst
class allowing the user to specify a path to the fluxfile. It will default to the one defined by the SBNDATA_DIR
envvar.
This PR tied closely with sbndata PR#4 Update NuMI flux file to latest version.
The updates here are necessary to access data correctly from the flux file in the above PR, as the internal structure of the file has undergone several revisions.
Specific Updates:
sbndata
that needs to be accessed has been moved from a local variable ofNuMIFluxSyst::Shift
to a private member variable of theNuMIFluxSyst
class as a whole. My opinion is that it will be easier to locate and update down the line, this way. Although, I'm not a fan of having the filename hard-coded into the class, as it has to be updated separately in the newNuMIPpfxWeight
class, but I don't have a better solution at the moment.NuMIPpfxWeight
class and correspondingVar
to facilitate extracting the NuMI flux weights, so I've incorporated that into this PR. Just as a simple test that it's working as expected, I've pulled a small distribution of flux weights:Other modifications:
attenuation
has been renamed toatt
beam_divergence
-->beam_div
horn1_position_xy
separated intohorn1_x
andhorn1_y
horn_current
-->horn_current_plus
(the -2kA sample found to be consistent with statistical fluctuations, so we dropped it)horn2_position_xy
removedbeam_spot_size
-->beam_spot
beam_shift_minus_y
andbeam_shift_plus_y
split frombeam_shift_xy
(x-shift samples dropped; consistent with stat. flucts.)B_field
removedAgain to check that this update still works as expected, below are a selection of true neutrino energy spectra varied according to the various systematics.