search

SBNSoftware / sbnci

Packages, modules and scripts for the SBN continuous integration system
2 stars 4 forks source link

How should we handle validation tasks common to both sbndcode and icaruscode? #19

Closed chilge closed 2 years ago

chilge commented 3 years ago

Could we introduce some base class with the common elements with experiment specific implementations on top? @rennney what was your experience in modifying existing modules for use with icaruscode? Is something we that could be done "easily"?

rennney commented 3 years ago

I have only one general comment, especially if modules are going to be generalized. Most of my issues came from sbnd modules being written with one module lable in mind. In some cases, it is unclear how to correctly add more labels and not break the logic; however, that might be due to my little experience with larsoft.

chilge commented 2 years ago

I am nearing completion of my implementation of a solution to this question. If you're interested, see feature/chilgenb_CommonCode.