This branch started about 6 weeks ago as a fix to a SimChannel issue from the refactored larg4 and has grown to encompass all manner of fall out from said event as well as some other catch alls. I know its bad form so apologies for that, I'll separate out what each commit contains.
@absolution1 could you review these commits please?
019df85 and b1bf84c contain the required changes to use the new simdrift module label.
b692254 these exist in simulation services, don't know why we don't use them? Same is true in sbndcode but one step at a time ey
63677cb provides accurate efficiency, completeness and purity calculations for showers with any need for roll up to be turned on
98b61df with rollup off this stops the plots getting drowned out
fa53939 tidy up my naming for the rollup patch, also rolls up delta rays into muons (as this was causing muon plots to look like degrading performance) but does so in a sketchy way which I will remove once the rollup issue is sorted
92bcb07 shower validation has always had silly binning, lets sort this out!
@vitodb could you review this commit please?
9ee2432 the errors on TEfficiency's were being reset to sqrt(N) which doesn't make sense. This should now preserve the sensible errors. It also adds functionality for the ratio plot to have more flexible ranges to see what is going on.
This branch started about 6 weeks ago as a fix to a SimChannel issue from the refactored larg4 and has grown to encompass all manner of fall out from said event as well as some other catch alls. I know its bad form so apologies for that, I'll separate out what each commit contains.
@absolution1 could you review these commits please? 019df85 and b1bf84c contain the required changes to use the new
simdriftmodule label. b692254 these exist in simulation services, don't know why we don't use them? Same is true insbndcodebut one step at a time ey 63677cb provides accurate efficiency, completeness and purity calculations for showers with any need for roll up to be turned on 98b61df with rollup off this stops the plots getting drowned out fa53939 tidy up my naming for the rollup patch, also rolls up delta rays into muons (as this was causing muon plots to look like degrading performance) but does so in a sketchy way which I will remove once the rollup issue is sorted 92bcb07 shower validation has always had silly binning, lets sort this out!@vitodb could you review this commit please? 9ee2432 the errors on TEfficiency's were being reset to sqrt(N) which doesn't make sense. This should now preserve the sensible errors. It also adds functionality for the ratio plot to have more flexible ranges to see what is going on.