search

SBNSoftware / sbnci

Packages, modules and scripts for the SBN continuous integration system
2 stars 4 forks source link

Feature/chilgenb common code #31

Closed chilge closed 3 years ago

chilge commented 3 years ago

significant overhaul of sbnci to put sbndcode and icaruscode on equal footing. where possible and straightforward, analyzer modules have been combined with only different FHiCLs required to run the exp specific code. this branch has a sister branch in lar_ci,feature/chilgenb_SBNCI_CommonCode that is required to be used with this branch, i.e. this branch will not work with lar_ci@develop.

chilge commented 3 years ago

Thank you thank you thank you for the thorough review @henrylay97! Your comments are immensely helpful, and I will address them promptly.

chilge commented 3 years ago

thanks again @henrylay97! :)

chilge commented 3 years ago

All production and validation workflows have been tested. The only thing that doesn't work right now is the TPC reco validation for icaruscode due to an issue on the icaruscode side addressed in PR #281. I believe we can now merge this branch into develop.