search

SBNSoftware / sbnci

Packages, modules and scripts for the SBN continuous integration system
2 stars 4 forks source link

PFP Validation Modules #6

Closed henrylay97 closed 3 years ago

henrylay97 commented 3 years ago

Adding Ed's PFP Validation Modules and the all the plotting machinery to go with them. Has been tested and used in validating a reconstruction change. Part of an effort to combine the usage of the different reconstruction validation modules into one consolidated workflow.

henrylay97 commented 3 years ago

Thanks for taking a look so quickly Vito! I have updated the bash scripts and will update the threshold files for all validation wfs in a separate PR.

etyley commented 3 years ago

Is this PR based on my branch of a similar name? I can see you have added the same files but can't see if there are any changes with respect to that branch. If it is, could you change to base of what this PR is being compared against?

henrylay97 commented 3 years ago

@etyley yep sorry it is. The only commit that affects your stuff is this the rest was just so I had all of the plotting machinery in one place :)

etyley commented 3 years ago

Okay that looks good to me. The only comment would be to maybe put it inside a fcl controllable if statement in case anyone wants to ever disable it for whatever reason.

henrylay97 commented 3 years ago

That's a good shout I will do so. Thanks v much for taking a look! :)