search

SBNSoftware / sbnci

Packages, modules and scripts for the SBN continuous integration system
2 stars 4 forks source link

Functionality for combined reconstruction workflow and fcl clean up #9

Closed henrylay97 closed 3 years ago

henrylay97 commented 3 years ago

This is the last in the recent series of PRs, thanks for putting up with me! This one provides the functionality to use all 4 reconstruction validation modules in one workflow. I presented information about this workflow at the most recent CI & Validation meeting.

When creating the fcl to run all 4 in one job I realised how messy the different fcl approaches were, just a natural effect from different people importing their own modules. I've tried to clean them up and make them all stylistically consistent. This involved making a JobConfigurations folder with all the job-type fcls. They all use prolog type fcls in the relevant modules folder. I'm hoping this makes it easier for people adding modules in the future and also for changing/creating new configurations or adding configurations for ICARUS.

miquelnebot commented 3 years ago

@henrylay97 is this good to go?

henrylay97 commented 3 years ago

I'll drop @chilge a message today just to check he's happy and let you know :)

chilge commented 3 years ago

Looks good to me!