search

SBNSoftware / sbndcode

10 stars 43 forks source link

Add new functions in geometry helper #441

Closed yangtj207 closed 3 months ago

yangtj207 commented 3 months ago

Add a function to calculate the intersection point of two wires. Add an analyzer module to analyzer channel ID data.

fjnicolas commented 3 months ago

I'll go ahead and approve this, but the person doing the merge should check PR 443 as well -- there are commits with the same comments and what looks like the same changes in that. Maybe the same branch was used for both PRs?

thanks for the warning @tomjunk, looks like that's the case. I'll take it into account for the merging process.

fjnicolas commented 3 months ago

trigger build

FNALbuild commented 3 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 3 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 3 months ago

:x: CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 3 months ago

:x: CI build for SBND Failed at phase unit_test SBND on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard