Closed yangtj207 closed 6 months ago
Looks okay, though it looks like this PR swept in the commits from PR 441. Maybe the same branch was used for both PRs?
Looks okay, though it looks like this PR swept in the commits from PR 441. Maybe the same branch was used for both PRs?
I'll rebase this after merging #441 to isolate the specific changes intended by this PR
Thank you. Yes, 441 and 443 are based on the same branch. I will try to using separate branches for different PR in the future.
trigger build
:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard
:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard
:x: CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the unit_test SBND phase logs
parent CI build details are available through the CI dashboard
:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs
parent CI build details are available through the CI dashboard
CI failures unrrelated to the PR
Add a module to make event displays. This can be potentially used by OM and other commissioning studies.
Here is one example: