search

SBNSoftware / sbndcode

11 stars 44 forks source link

Run mcreco with Dropped Particles #451

Closed bear-is-asleep closed 5 months ago

bear-is-asleep commented 6 months ago

MCReco needs inputs from both MCParticle lists to track down ancestory of EM shower daughters.

I also tacked on some small changes to the reco stage that makes a separate analyzer module for mpvmpr.

Also some changes to mpvmpr generator.

All of these changes are isolated to the ml reco workflow and should not effect the standard reco workflows, especially since Pandora no longer uses mcreco.

This PR is dependent on larsim PR133 being merged into sbncode.

bear-is-asleep commented 6 months ago

Sorry @lynnt20 and @fjnicolas this is a lot for a single PR, but it all is isolated to ML reco so it should still be easy to review.

fjnicolas commented 6 months ago

hi @bear-is-asleep is this needed por production or can get in later? I was planning to cut production release based on current develop and larsoft/sbncode v09_88_00

bear-is-asleep commented 6 months ago

hi @bear-is-asleep is this needed por production or can get in later? I was planning to cut production release based on current develop and larsoft/sbncode v09_88_00

It's low priority to get in, so if it holds up production please feel free merge it afterwards!

fjnicolas commented 5 months ago

trigger build

FNALbuild commented 5 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 5 months ago

:x: CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 5 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 5 months ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard