search

SBNSoftware / sbndcode

11 stars 44 forks source link

increase precision of timestamp calculation to 64 bits -- was 32 bits #463

Closed tomjunk closed 4 months ago

tomjunk commented 5 months ago

The TPC Analysis data product that the raw decoder makes had a 32-bit timestamp which is inadequate. I had copied it from here:

https://github.com/SBNSoftware/sbndqm/blob/bbdb305238b32b4d3d215bba47ea1bf44ba97b6c/sbndqm/Decode/TPC/HeaderData.hh#L21

I changed the data type to ULong64_t from uint32_t in the data product, and upgraded the formula computing it so that it doesn't roll over at 2E9 or so. The classes_def.xml file automatically updated, and ROOT's automatic schema evolution should take care of reading in old files as only the size of one element of the data product changed. I checked reading in an old and a new analysis data product in the same ROOT session in the same TTree, and ROOT figured it out. Below are results of a test of redecoding a file and looking at the timestamp vs. the entry number in the file.

run12804_rollover norollover

tomjunk commented 5 months ago

trigger build

FNALbuild commented 5 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 5 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 5 months ago

:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 5 months ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

fjnicolas commented 5 months ago

@tomjunk I'll include this in the next release