search

SBNSoftware / sbndcode

10 stars 43 forks source link

CRT Decoder & Channel Map #470

Closed henrylay97 closed 2 days ago

henrylay97 commented 1 month ago

I've extracted the CRT decoder and channel map from the offline reconstruction branch we've been working on at FNAL. This should be enough to start adding the CRT decoder to the automatic decoder processes.

Note that this implementation of the channel map only contains the North, East and Flat modules. The West wall is currently in the data stream, channel map to come. There are also 3 modules (2 on the north and 1 on the flat) which have no corresponding module in the current geometry version. The decoder deals with this gracefully, putting a message in the log and printing a summary message to cout at the end of the job with a summary of which modules it didn't find.

henrylay97 commented 1 month ago

@tbwester note the update today to include the West Wall. Thanks to Nikki Pallat!

RachelCoackley commented 3 weeks ago

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00 SBNSoftware/sbncode@v09_90_00 SBNSoftware/sbndcode@v09_90_00

FNALbuild commented 3 weeks ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 3 weeks ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 3 weeks ago

:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 3 weeks ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

henrylay97 commented 3 weeks ago

Sorry to update it just after it's been reviewed. The updates are very minor and correspond to:

@tbwester updates as promised, sorry for the delay!

bear-is-asleep commented 2 weeks ago

Is this PR now contingent on geometry changes from PR478? I'm just wondering so I know if these need to be merged at the same time for example.

henrylay97 commented 2 weeks ago

Nope this could go in now. But as I mentioned in #478 it will require a further update which I could either add to this if still open, or make in a separate PR next week.

bear-is-asleep commented 1 week ago

Nope this could go in now. But as I mentioned in #478 it will require a further update which I could either add to this if still open, or make in a separate PR next week.

Hi Henry, I'm happy to do either, although I have a slight preference towards just adding the change to this code. Just let me know which one you'd like and your wish will be granted.

bear-is-asleep commented 1 week ago

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00

FNALbuild commented 1 week ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 1 week ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 1 week ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 1 week ago

:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

tomjunk commented 2 days ago

Sorry to be slow! Just seeing this. Looks like minor changes and of course any fixes to the mapping should go in.

One comment about verisoned map files -- if they are needed to read old and new data, then yes, absolutely keep each version with a version number. If a particular file contains a mistake and corresponds to no data at all, you can overwrite it with the corrected map -- no need to keep the incorrect one around in the release. But if the detector itself evolves, or the data format or even the larsoft geometry, then absolutely, keep the versions.