SBNSoftware / sbndcode

11 stars 44 forks source link

Solve compiling errors in SBNDPDSAnalyzer with c14 #471

Closed fjnicolas closed 4 months ago

fjnicolas commented 4 months ago

I saw c14 is throwing these compiling error after merging #467. This PR aims to address this.


5129: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/OpDetAnalyzer/PDSAnalyzer/SBNDPDSAnalyzer_module.cc:262:14: error: unused variable 'clockData' [-Werror,-Wunused-variable]
5130:   auto const clockData(timeservice->DataFor(e));
5131:              ^
5132: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/OpDetAnalyzer/PDSAnalyzer/SBNDPDSAnalyzer_module.cc:1001:12: error: explicitly assigning value of variable of type 'double' to itself [-Werror,-Wself-assign]
5133:     dE_tpc0=dE_tpc0;
5134:     ~~~~~~~^~~~~~~~
5135: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/OpDetAnalyzer/PDSAnalyzer/SBNDPDSAnalyzer_module.cc:1012:12: error: explicitly assigning value of variable of type 'double' to itself [-Werror,-Wself-assign]
5136:     dE_tpc1=dE_tpc1;
5137:     ~~~~~~~^~~~~~~~
5138: In file included from /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/OpDetAnalyzer/PDSAnalyzer/SBNDPDSAnalyzer_module.cc:1:
5139: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/OpDetAnalyzer/PDSAnalyzer/SBNDPDSAnalyzer_module.hh:181:7: error: private field '_nMCParticles' is not used [-Werror,-Wunused-private-field]
5140:   int _nMCParticles;                        
5141:       ^
fjnicolas commented 4 months ago

trigger build

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 4 months ago

:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 4 months ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

fjnicolas commented 4 months ago

@bear-is-asleep c14 looks "happy" now :); it compiles and we get the usual data production error for the CI tests