search

SBNSoftware / sbndcode

10 stars 43 forks source link

Add fcls tuned to pmt data #474

Closed bear-is-asleep closed 1 month ago

bear-is-asleep commented 1 month ago

The hitdumper can run successfully with pmt decoded data. However, some tuning is needed for the OpHitFinder for the raw waveform, which is included in a separate fcl. I've also added a separate configuration fcl, that will only read data. For now it only reads pmts, but as more subsytems come on they can be added.

image Above is all pmt waveforms from run 12877. The red lines show the expected region of noise PedRangeMax/Min and the blue line is the ADC threshold, which is the same as the standard fcl, 13 ADC.

lynnt20 commented 1 month ago

instead of making an entirely new config fcl that is nearly identical, I would suggest adding onto the original config fcl file and call another instance with a new name, that has some fcl parameters changed. Example here (wirecell configs).

The base config is sbnd_wcls, and sbnd_wcls_simsp and sbnd_wcls_sp inherit from the base one. I think this will ultimately lead to less confusion down the line, especially if you change the defaults for the base, then it'll propagate through all other configs that reference it.

bear-is-asleep commented 1 month ago

trigger build

FNALbuild commented 1 month ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 1 month ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 1 month ago

:x: CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 1 month ago

:warning: CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard