Closed djpayne-thing closed 3 months ago
Hi @djpayne-thing , can you assign a reviewer please?
Looks like I can assign myself. Is that appropriate?
It's typical to have someone else review, so there are multiple eyes on it. Are there any other CRT experts who can check the geometry? @henrylay97 comes to mind.
Looks like I can assign myself. Is that appropriate?
@djpayne-thing it must be someone different than the PR author (actually GitHub doesn't allow you to do that). Probably simulation conveners or people previously working on geometry (e.g. @gustavogx @mrguzzo) are good options
This is what the changes I've made look llike
This is really great, thanks @djpayne-thing!
Marco's comment is important for picking up the geometry updates when we run jobs.
@bear-is-asleep I will need to keep in the loop when this goes into a release so that I can make sure the channel mapping in that release matches this geometry.
Mainly for the record of the PR but also for my total clarity could you list what does change in this update? (I think it's adding the extra flat module, shifting the horizontal north wall modules on the west side down a little and adding the two square modules in the bottom corner? Is that right?)
Added a separate pull request for geometry_sbnd.fcl
I've realized there's an additional change relative to the original that should also be in here. I'll close this and make a fresh pull request
Updates the CRT geometry to something a bit closer to what we built. Does not include gaps, etc, but this is more or less what exists. Does not include the skinny modules under the cryo valve. Top CRT is closer to what will actually exist than it was. It's a process.