search

SBOHVM / RPiR

The Reproducible Programming in R course, developed by the School of Biodiversity, One Health and Veterinary Medicine at the University of Glasgow.
https://sbohvm.github.io/RPiR/
GNU General Public License v3.0
12 stars 2 forks source link

Closes #166 #168

Closed soniamitchell closed 3 years ago

soniamitchell commented 3 years ago

Closes #172

soniamitchell commented 3 years ago

Fixed "can't install" RPiR in CI. Added test for broken -hint chunks.

richardreeve commented 3 years ago

@soniamitchell By the way, you need to put the "closes" statement in the text of a comment to get automatic closing to work I think... though I see you then did it in one of the actuall commits instead.

soniamitchell commented 3 years ago

In a commit message? Sometimes I forget.. so I've been randomly commenting to make some kind of trail...

richardreeve commented 3 years ago

If you just say here that it closes #166 then when you merge the PR, #166 will be closed. You can tell because you get the little dots underlining the word "closes".

Edit: this doesn't seem to be working at the moment, maybe because this is already merged and #166 is closed!

soniamitchell commented 3 years ago

So I guess the comments are what is described in the documentation as the description then?

Does my using Closes in the commit message not work? Because it should... https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

richardreeve commented 3 years ago

Yes, it does work, and yes this text here is apparently a description - seems like a v bad name?! But in a commit it's not clear what it's referring to because git commits aren't tied to github. Whereas in a github PR, it's obvious it's referring to a github issue.

soniamitchell commented 3 years ago

I see 👍

richardreeve commented 3 years ago

People do put these statements in the commit messages all the time, but it feels to me like they are confusing git and GitHub when they do that.

soniamitchell commented 3 years ago

No, it does make sense. As one of those people that has never used git without GitHub, it took a moment to get my head around 🙈