search

SBOHVM / RPiR

The Reproducible Programming in R course, developed by the School of Biodiversity, One Health and Veterinary Medicine at the University of Glasgow.
https://sbohvm.github.io/RPiR/
GNU General Public License v3.0
12 stars 2 forks source link

Need to include gradethis and learnr in Imports #20

Closed richardreeve closed 3 years ago

richardreeve commented 3 years ago

Closes #19 - @soniamitchell - if you do:

remove.packages(c("learnr", "gradethis", "RPiR"))
devtools::install_github("IBAHCM/RPiR")
library(learnr)

remove.packages(c("learnr", "gradethis", "RPiR"))
devtools::install_github("IBAHCM/RPiR#20")
library(learnr)

with and without this fix, does the former error for you, but not the latter? If so, I think this is good to go... please do merge it. Otherwise let me know.

richardreeve commented 3 years ago

Windows seems to install glue multiple times for no obvious reason... not sure if it's real?

richardreeve commented 3 years ago

Good luck with fixing it... you don't need to update the version number by the way - I haven't merged this yet.

soniamitchell commented 3 years ago

Thanks! and good catch with the Imports field. I must have been sleeping.

The {glue} installs are dependencies of dependencies. I'm not sure multiple installs is unusual, but for some reason Windows is unhappy with {glue}. I appear to have gone down a rabbit hole...

richardreeve commented 3 years ago

We need to find someone with Windows to check whether it actually works... or maybe we could get rid of learnr as an import, because it's a dependency of gradethis and maybe then there won't be duplicated dependencies?

soniamitchell commented 3 years ago

Yea.. I thought about that.. but didn’t like it because {learnr} really is one of our dependencies..

And as far as I can see, a Windows install should be fine. If a warning like this is encountered, a restart of Rstudio should help..

Also, FYI.. I emailed a request for help last night. Fingers crossed we get a response soon.

soniamitchell commented 3 years ago

Turns out {usethis} also has a dependency on {glue}... and Windows is failing the CI again...

soniamitchell commented 3 years ago

Alright.. I've fixed it. We can add {learnr} back in as a dependency. We're using a new template, generated using {usethis}, which basically ignore the warnings. Turns out there are multiple packages that generate this warning, {glue} was just the first. I was using an old template, possibly customised..