SBPrime / AsyncWorldEdit-Premium

Async WorldEdit - Edit millions of blocks without lag! (Premium version)
Other
19 stars 4 forks source link

Nothing to undo #245

Closed x1p closed 3 years ago

x1p commented 3 years ago

I've setup AWE so that it remembers undo actions to a certain time. After reconnecting, AWE refuses to undo. Nothing to undo.

The /undo/my-uuid-folder contains my files alright. It makes 4 files per action. As long as I don't rejoin, the undo action is performed. But my goal is to accept undo actions for a certain amount of time, regardless of rejoining. This due to staff must be able to switch servers if priority asks for it. When they return to the original server they should be able to pickup where they left.

config.txt

AWE 3.8.1 WE 7.2.0 Paper 1.16.3-1.16.4

x1p commented 3 years ago

FYI: if AWE is loaded, it always says 0 blocks affected Purely WE does count affected block correctly

SBPrime commented 3 years ago

Please clarify one thing: normal undo works? This option should allow you to do what you need:

#How much time should the WorldEdit session be kept after player logged out
#Values: -1 Do not remove, 0 - immediately, X - Number of minutes
keepSessionOnLogoutFor: 60

For this option to work properly the user UUID needs to stay the same between logout/login.

x1p commented 3 years ago

Normal undo works, as long as the player is online and stays online.

I attached my config, so you could see my settings. I have had for a really long time this value: keepSessionOnLogoutFor: 60 which used to work fine. I needed it a few days ago and I noticed it didn't work. I had to recover a backup in order to undo this action.

The UUID is always the same. Server is in online mode through bungee

SBPrime commented 3 years ago

Nothing regarding the undo changed, could you do som tests on your end? a small edit + logout + login + undo would be enough. What operation did you try to undo? you can also try setting awe to debug mode and checking the logs for undo storage messages. I would also suggest doing this:

  1. clean the undo dir for player
  2. login
  3. small edit
  4. check the undo dir for player
  5. logout
  6. login
  7. 2nd small edit
  8. check the undo dir for player
  9. undo
  10. undo
  11. check the undo dir for player
x1p commented 3 years ago

Nothing regarding the undo changed, could you do some tests on your end?

The bug probably exists for a while. I didn't try older versions.

Regarding the test: 1: Screenshot_1

4: Screenshot_4

8: Screenshot_8

9: Screenshot_9

10: To my surprise, this time he said he had undone something, but failed to remove Screenshot_10

11: Screenshot_11

12: Tried to undo for the third time: Screenshot_12

SBPrime commented 3 years ago

I identified and fixed the problem, I will push the fix in next version (3.8.2).

x1p commented 3 years ago

Edit, oh wait, I'm dumb, I forgot to replace the default file again :) That's what you get when you perform numerous tests and you forget which config is in place. Works indeed fine now. Awesome 👍