search

SBRG / MASSpy

https://masspy.readthedocs.io
MIT License
22 stars 6 forks source link

Relax matplotlib requirement for easier installation #157

Closed jonrkarr closed 2 years ago

jonrkarr commented 3 years ago

matplotlib 3.2 has extra requirements for libfreetype6-dev. If possible, it would be helpful to relax this to something like matplotlib >= 3.2.

z-haiman commented 3 years ago

There is a specific function in matplotlib (rc.validate_legend_loc) that gets deprecated. Once removed, the requirement can be relaxed.

Line 571

https://github.com/SBRG/MASSpy/blob/1288834750a92f765cb6d97e16b28af7c9ba088a/mass/visualization/visualization_util.py#L366

I have it removed in the 0.2.0 version that's being developed currently

jonrkarr commented 3 years ago

I wasn't sure if MASSpy requires a specific version.

Alternatively, could you make matplotlib an optional requirement similar to Escher?

z-haiman commented 3 years ago

Definitely, I can make that happen in the 0.2.0 version.

Also, feel free to reach out to me too if there is anything specific you are looking to accomplish

z-haiman commented 2 years ago

@jonrkarr I believe I found a way to make the install for matplotlib optional. Let me know if this works for you

jonrkarr commented 2 years ago

That would be a helpful solution. setuptools.setup has an argument for optional dependencies.

z-haiman commented 2 years ago

Relaxed the requirement/made it optional, let me know if it works!

jonrkarr commented 2 years ago

The revised dependencies is great. This makes it easier to create a single Python environment with many simulation tools, which is helpful to a few groups.

jonrkarr commented 2 years ago

This is already working with 0.1.5.

z-haiman commented 2 years ago

Awesome, I'll close this issue then!