search

SBRG / bigg_models

The BiGG Models website server
http://bigg.ucsd.edu
Other
80 stars 18 forks source link

`iCN718` is not valid SBML due to reaction with no reactants or products #384

Open jonrkarr opened 3 years ago

jonrkarr commented 3 years ago

The model is not valid SBML because the reaction R_DNADRAIN does not have any reactants or products.

jonrkarr commented 3 years ago

This could be resolved by deleting this reaction from the model. With that one change, the model will be valid and appears to execute correctly.

matthiaskoenig commented 3 years ago

This could also be solved by just storing the file as SBML L3V2 which relaxes the rules on reactions. I.e. in L3V2 reactions without reactants or products are valid.

draeger commented 3 years ago

For annotation purposes, keeping an empty reaction may be useful, e.g., as a placeholder for later model improvement. I, therefore, agree with @matthiaskoenig that migrating to SBML L3V2 would be the better option if keeping this reaction is important. If it is mistakenly included, it should be deleted to comply with the SBML Level 3 Version 1 standard.