Previous code identifies different optimal thresholds

SBRG / pymodulon

Python package for analyzing and visualizing iModulons

MIT License

11 stars 13 forks source link

Previous code identifies different optimal thresholds #30

Closed avsastry closed 3 years ago

avsastry commented 4 years ago

Is it the same method that ICA codebase (3_estimate_thresholds) uses (which is also Modulytics instruction is referring to)?

(3_estimate_thresholds)

For some reason, the code on my computer didn't calculate them properly (If so, why?) so I need to manually call the function (reoptimize_thresholds).

But the best cutoff value obtained by the ICA codebase 3_estimate_threshold was "1050" while ica_data.reoptimize_thresholds() in pymodulon yielded "1150" Was there any change in the optimization?

avsastry commented 4 years ago

@hyungyulim I will post updates here

avsastry commented 3 years ago

So it doesn't seem that this affects any of the published datasets (e. coli, s. aureus, b. subtilis), so I'm going to close this out for now.