SBRG / pymodulon

Python package for analyzing and visualizing iModulons
MIT License
11 stars 13 forks source link

Added test function and new logic for deciding thresholds #77

Closed avsastry closed 3 years ago

avsastry commented 3 years ago

A few things in this pull request: 1) Removed the ability to pass in thresholds as a list for ica_data.thresholds = <thresholds>, only allowing dictionary entries due to ambiguity in iModulon ordering 2) Added rigorous test functions to ensure that the threshold logic was both clear and accurate when creating a new IcaData object 3) Added a new fit_metric=None option for plotting, in case you didn't want a best fit line.

Resolves #76, resolves #62