search

SBRG / pymodulon

Python package for analyzing and visualizing iModulons
MIT License
11 stars 13 forks source link

Imodulon vs regulon #85

Closed avsastry closed 3 years ago

avsastry commented 3 years ago

Adds a new imodulon_vs_regulon plot. Closes #83

Anyone have other functionality that should be added?

avsastry commented 3 years ago

Final commit has the specific changes, the previous commits are part of a different pull request

kevin-rychel commented 3 years ago

Looks great! My only comment is on the capitalization in the axes labels -- either de-capitalize "Regulon" or capitalize "shared genes" and "size". Given that the rest of the package tends toward more capitalization, I'd say to capitalize all the words in the axes labels.

If possible, a legend with the size ranges would be cool. But I don't think it's necessary.

avsastry commented 3 years ago

Looks great! My only comment is on the capitalization in the axes labels -- either de-capitalize "Regulon" or capitalize "shared genes" and "size". Given that the rest of the package tends toward more capitalization, I'd say to capitalize all the words in the axes labels.

Done

If possible, a legend with the size ranges would be cool. But I don't think it's necessary.

I'll add it to the issue tracker