search

SBU-BMI / SlicerPathology

3D Slicer extension for Pathology segmentation tools
http://bmi.stonybrookmedicine.edu
Other
5 stars 8 forks source link

Fix build error against Slicer trunk #102

Open jcfr opened 6 years ago

jcfr commented 6 years ago

macOS

See http://slicer.cdash.org/viewBuildError.php?buildid=1281642

SlicerPathology/QuickTCGA/Logic/NucleusSeg_Yi/ConnComponents.h:17:10: fatal error: 'tr1/unordered_map' file not found

See below.

Linux

See http://slicer.cdash.org/viewBuildError.php?buildid=1281331

vtkWrapHierarchy-9.0: In SlicerPathology/QuickTCGA/Logic/TCGAUtilities.h:75: syntax error.

I suggest to explicitly exclude the header from the wrapping. For example, see https://github.com/Slicer/Slicer/blob/d258a316fcdf4bd91098a4faf3c32ffa4ebdc094/Libs/vtkAddon/CMakeLists.txt#L76-L80

Windows

See http://slicer.cdash.org/viewBuildError.php?buildid=1281486

d:\d\p\s-0-e-b\slicerpathology\quicktcga\logic\nucleusseg_yi\ConnComponents.h(17): 
fatal error C1083: Cannot open include file: 'tr1/unordered_map': 
No such file or directory [D:\D\P\S-0-E-b\SlicerPathology-build\QuickTCGA\Logic\NucleusSeg_Yi\NucleiSegLib.vcxproj]

You could implement a compiler check like what is done in SimpleITK. (Look for SITK_HAS_TR1_UNORDERED_MAP, ...)