search

SBU-BMI / SlicerPathology

3D Slicer extension for Pathology segmentation tools
http://bmi.stonybrookmedicine.edu
Other
5 stars 8 forks source link

Numerous build errors on Mac and Linux - extension is expected to be unavailable to the users #49

Closed fedorov closed 8 years ago

fedorov commented 8 years ago

image

fedorov commented 8 years ago

http://slicer.cdash.org/index.php?project=Slicer4&display=project

fedorov commented 8 years ago

@naucoin can help @ebremer look into this?

naucoin commented 8 years ago

Looking into it now, suspecting VTKv7 migration issues.

fedorov commented 8 years ago

errors for linux: http://slicer.cdash.org/viewBuildError.php?buildid=864970

Slicer r25242

ebremer commented 8 years ago

Compiled on Ubuntu 16.x as of today

ebremer commented 8 years ago

trunk@25237

ebremer commented 8 years ago

Compiles and runs fine on an clean Ubuntu 14.x machine

naucoin commented 8 years ago

Determined so far on sentinelle:

There is a change in VTK7 to allow using WRAP_EXCLUDE_PYTHON not just a general WRAP_EXCLUDE command, but that gets ignored as well: http://www.vtk.org/Wiki/VTK/Python_Wrapping_FAQ @msmolens committed a change to SlicerPathology to fix this on Jul 11: https://github.com/SBU-BMI/SlicerPathology/commit/c82a227e2b4c41799ed58c5df3bb93951ceab561 but the SlicerPathology.s4ext currently in the extension index is pointing to a hash from Jun 21, not master: https://github.com/Slicer/ExtensionsIndex/commit/e6bb2ad76f843697ac826485e4fe49374b326382

This pull request should fix building on the factory on Linux and Mac: https://github.com/Slicer/ExtensionsIndex/pull/1347

fedorov commented 8 years ago

Sounds promising, thanks for investigating this!

I see, I reset it from master. We should change it to point to master.

fedorov commented 8 years ago

resolved, @naucoin will add details

naucoin commented 8 years ago

The pull request above fixed building SlicerPathology, and this change to Slicer fixed the failing tests on Windows for SlicerOpenCV: https://github.com/Slicer/Slicer/commit/96c1d59ed0b2847e3c526be8063ca786429a92bf so now SlicerPathology is building on the factory on windows.

tdiprima commented 7 years ago

I resolved the Linux/Mac/Windows compiler issues some time at the end of April 2017. Additionally, the Mac and Windows compile errors were fixed in #81.