SBU-BMI / SlicerPathology

3D Slicer extension for Pathology segmentation tools
http://bmi.stonybrookmedicine.edu
Other
5 stars 8 forks source link

Unintended indentation L261-L262 #61

Closed tdiprima closed 7 years ago

tdiprima commented 7 years ago

@ebremer It looks these those 2 lines need to be outdented. Because we're done with the if ei not in params block. Please have a look & confirm — in function updateSliders().

tdiprima commented 7 years ago

I meant to make a branch but I accidentally hit the button before it let me create a branch, so it went into master by mistake. :(

So I reverted your code to the way you originally had it.

But, I still think those 2 lines need to be outdented.

Because right now, it reads:

if ei not in params:
...
      jstr = json.dumps(params,sort_keys=True, indent=4, separators=(',', ': '))
      self.parameterNode.SetParameter("QuickTCGAEffect,erich", jstr)

Whereas it probably should be the same as the function below it:

if ei not in self.params:
    # do stuff...

jstr = json.dumps(self.params,sort_keys=True, indent=4, separators=(',', ': '))
self.parameterNode.SetParameter("QuickTCGAEffect,erich", jstr)