search

SBU-BMI / quip_distro

BSD 3-Clause "New" or "Revised" License
29 stars 16 forks source link

Enhanced tag handling #296

Closed tdiprima closed 6 years ago

tdiprima commented 6 years ago

Issue: #295 This proposed solution is what we discussed on today's call. There are two things I want to give the heads-up on:

  1. As some of you have already observed, if you do not run run_containers.sh as root, the following would fail quietly. But In the proposed version, it will alert you that you need to run it as root.
    sed 's/\@QUIP_JOBS/\"quip-jobs\"/g' $CONFIGS_DIR/config_temp.json > $CONFIGS_DIR/config_tmp.json
    sed 's/\@QUIP_OSS/\"quip-oss:5000\"/g' $CONFIGS_DIR/config_tmp.json > $CONFIGS_DIR/config.json
    sed 's/\@QUIP_DATA/\"quip-data\"/g' $CONFIGS_DIR/config.json > $CONFIGS_DIR/config_tmp.json 
    sed 's/\@QUIP_LOADER/\"quip-loader\"/g' $CONFIGS_DIR/config_tmp.json > $CONFIGS_DIR/config.json
  1. camicroscope/oss-lite does not have a tagged release.

Open to suggestions, recommendations, and comments!

Thanks.

ebremer commented 6 years ago

I would think oss-lite should get a tag

ebremer commented 6 years ago

Why exactly is the above failing without root?

tdiprima commented 6 years ago

@ebremer

Why exactly is the above failing without root?

My understanding is the containers are writing to your "data" folder in your home directory, as root. Therefore, as you know, you can't modify in the folder without doing "sudo" first.

tdiprima commented 6 years ago

@ebremer

I would think oss-lite should get a tag

Agreed. Keep in mind, at the moment we are not cloning and building oss-lite; but rather we are pulling the image from docker hub (subtle difference, the code doesn't make it obvious).