search

SBU-BMI / wsinfer

🔥 🚀 Blazingly fast pipeline for patch-based classification in whole slide images
https://wsinfer.readthedocs.io
Apache License 2.0
56 stars 9 forks source link

pin tifffile dependency to something greater than version 2023.* #154

Closed kaczmarj closed 1 year ago

kaczmarj commented 1 year ago

Using a tifffile version from 2021 was incompatible with tiffslide. To be on the safe side, let's pin the tifffile version to something equal to or newer than 2023.*.

The change would have to be made in setup.cfg.

swaradgat19 commented 1 year ago

I've committed the change. Could you give me access so that I can push and open a PR

kaczmarj commented 1 year ago

@swaradgat19 - make a fork of the project, branch off of main, commit the change, and submit a pr back to this repo

kaczmarj commented 1 year ago

@swaradgat19 - we should pin the following dependencies

imagecodecs >= 2023.7.10  # https://github.com/Bayer-Group/tiffslide/issues/72#issuecomment-1630091390
tifffile >= 2023.1.23
tiffslide >= 2.2.0  # https://github.com/Bayer-Group/tiffslide/issues/72#issuecomment-1631015274
swaradgat19 commented 1 year ago

Got it. Making the changes

swaradgat19 commented 1 year ago

@kaczmarj - imagecodec >= 2023.7.10 will go in the dev section right? And tifffile and tiffslide in the requires section

kaczmarj commented 1 year ago

good question. let's move it into the install_requires section.

imagecodecs is a dependency of tifffile and tiffslide, and that imagecodecs had a speed improvement in 2023.7.10 that is relevant to our use cases.

swaradgat19 commented 1 year ago

Ah makes sense. I have opened a PR