search

SBU-BMI / wsinfer

🔥 🚀 Blazingly fast pipeline for patch-based classification in whole slide images
https://wsinfer.readthedocs.io
Apache License 2.0
56 stars 9 forks source link

Fix/setup.cfg #157

Closed swaradgat19 closed 1 year ago

swaradgat19 commented 1 year ago

Pinned imagecodecs, tiffslide and tifffile in setup.cfg

fixes #154

kaczmarj commented 1 year ago

@swaradgat19 - thanks! looks great. i added two comments to the setup.cfg so we know why these packages are pinned to those versions.

the python 3.8 test is failing because the latest version of imagecodecs isn't built for python 3.8.

i think adding this will fix it...

imagecodecs >= 2022.7.27 ; python_version<3.9
# https://github.com/Bayer-Group/tiffslide/issues/72#issuecomment-1630091390
imagecodecs >= 2023.7.10 ; python_version>=3.9
swaradgat19 commented 1 year ago

@kaczmarj Right. I'll do the changes.

swaradgat19 commented 1 year ago

The rest of them are canceled since the 3.8 test didn't pass right?

kaczmarj commented 1 year ago

some tests passed, two tests are still running. the tests across python 3.8-3.11 all stopped because 3.8 failed.

swaradgat19 commented 1 year ago

Yeah I meant the 3.9-3.11 ones. Got it

swaradgat19 commented 1 year ago

@kaczmarj Added the comments as well. Does the syntax go imagecodecs >= 2022.7.27 ;python_version<"3.9" , with the quotes. Saw it here link. Let me know if changes are required.

kaczmarj commented 1 year ago

@swaradgat19 - yes, looks like the quotes around the python version are important. can you make that change?

swaradgat19 commented 1 year ago

@kaczmarj Yes. I've pushed the changes