search

SBoudrias / gruntfile-editor

An API to modify a Gruntfile.js content
MIT License
40 stars 10 forks source link

Create insertJavaScript method #29

Closed keirlawson closed 9 years ago

keirlawson commented 9 years ago

To fix https://github.com/SBoudrias/gruntfile-editor/issues/9, feedback appreciated!

keirlawson commented 9 years ago

@SBoudrias any feedback? Able to merge?

SBoudrias commented 9 years ago

Hey, this is in my pipeline, I'm just a bit busy for reviews/coding lately.

SBoudrias commented 9 years ago

I think it's be better if we renamed this method prependJavaScript() (as we could add a method to append code too).

Also, can we update insertVariable to also use this method?

keirlawson commented 9 years ago

Thanks for your feedback, have made changes requested, let me know if it looks ok :)

SBoudrias commented 9 years ago

Alright, that LGTM. Can you squash your commits in a single one?

keirlawson commented 9 years ago

Done

SBoudrias commented 9 years ago

Nice! Thanks a lot!